Fix kanban column height calculation for quickview#477
Merged
Conversation
Three fixes to the kanban height calculation: 1. Use lipgloss.Height() to measure actual rendered header height instead of len(headerParts) which only counts parts (not lines). If any banner text wraps due to terminal width, this caused the kanban to render too tall, clipping the bottom content behind the quickview. 2. Call ensureSelectedVisible() in SetSize() when height changes so scroll offsets adjust when the executor prompt preview appears/disappears. Previously, scroll offsets were only recalculated on navigation, so tasks at the bottom of columns could be pushed outside the visible area when the quickview reduced available height. 3. Fix handleClickDesktop() to subtract border height (-2) from colHeight, matching the calculation used everywhere else. This ensures click coordinate mapping is consistent with the rendered layout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lipgloss.Height()) instead of counting header parts (len(headerParts)), which undercounts when banner text wrapsensureSelectedVisible()call toSetSize()so scroll offsets adjust when the executor prompt preview appears/disappears, keeping bottom-of-column tasks visiblehandleClickDesktop()to subtract border height fromcolHeight, matching the calculation used in all other column height calculationsTest plan
go test ./internal/ui/)go test ./internal/...)🤖 Generated with Claude Code