Skip to content

Apply multiple-testing correction to omega outputs#452

Open
Copilot wants to merge 5 commits into
devfrom
copilot/apply-multiple-testing-correction-omega
Open

Apply multiple-testing correction to omega outputs#452
Copilot wants to merge 5 commits into
devfrom
copilot/apply-multiple-testing-correction-omega

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Omega results need independent multiple-testing correction across cohort, group, and per-sample comparisons, applied separately at gene and subgenic levels, for both omega and omegagloballoc outputs.

  • Multiple-testing correction pipeline

    • Added omega_multiple_testing.py to apply BH correction per {all_samples|group|sample} × {gene|subgenic} slice and emit pvalue_adj.
    • New Nextflow module OMEGA_MULTITEST runs the correction and replaces compiled omega outputs for both omega and omegagloballoc.
  • Workflow wiring + outputs

    • Hooked correction into OMEGA_ANALYSIS so all_omegas*.tsv and all_omegas*_global_loc.tsv are corrected before publish.
    • Published corrected files to existing selection output paths.
  • Tests/docs

    • Updated omega test expectations and README to require pvalue_adj.

Example correction behavior (BH per slice):

# pvalue_adj computed within each {cohort/group/sample} × {gene/subgenic} slice
omega_multiple_testing.py \
  --omegas-file all_omegas.tsv \
  --samples-json samples.json \
  --groups-json groups.json \
  --output all_omegas.tsv

Copilot AI and others added 3 commits May 13, 2026 12:18
Agent-Logs-Url: https://github.com/bbglab/deepCSA/sessions/0dc29618-9415-4b29-8cfd-475121150c33

Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bbglab/deepCSA/sessions/0dc29618-9415-4b29-8cfd-475121150c33

Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bbglab/deepCSA/sessions/0dc29618-9415-4b29-8cfd-475121150c33

Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Copilot AI changed the title [WIP] Add module for multiple testing correction of omega results Apply multiple-testing correction to omega outputs May 13, 2026
Copilot AI requested a review from FerriolCalvet May 13, 2026 12:22
@FerriolCalvet
Copy link
Copy Markdown
Member

@copilot repeat the process but using the dev branch as a starting point and also open the PR for dev not for main!

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 13, 2026

@FerriolCalvet I've opened a new pull request, #454, to work on those changes. Once the pull request is ready, I'll request review from you.

@FerriolCalvet FerriolCalvet changed the base branch from main to dev May 13, 2026 14:16
@FerriolCalvet FerriolCalvet marked this pull request as ready for review May 15, 2026 10:03
@FerriolCalvet
Copy link
Copy Markdown
Member

FerriolCalvet commented May 15, 2026

all works well, before merging, let's discuss if the implementation is exactly the one we want to use or not.

  • Decide how to deal with p-values that are set to 0.

Copy link
Copy Markdown
Member

@FerriolCalvet FerriolCalvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionally tested, but missing to agree on the details of the multiple testing correction

@FerriolCalvet
Copy link
Copy Markdown
Member

Assuming it is a float32 numeric type, we can use 1.17*10^{-38} as the minimum possible non-zero p-value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applying multiple testing correction for omega

2 participants