Apply multiple-testing correction to omega outputs#452
Open
Copilot wants to merge 5 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/bbglab/deepCSA/sessions/0dc29618-9415-4b29-8cfd-475121150c33 Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bbglab/deepCSA/sessions/0dc29618-9415-4b29-8cfd-475121150c33 Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bbglab/deepCSA/sessions/0dc29618-9415-4b29-8cfd-475121150c33 Co-authored-by: FerriolCalvet <38539786+FerriolCalvet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add module for multiple testing correction of omega results
Apply multiple-testing correction to omega outputs
May 13, 2026
Member
|
@copilot repeat the process but using the dev branch as a starting point and also open the PR for dev not for main! |
Contributor
Author
|
@FerriolCalvet I've opened a new pull request, #454, to work on those changes. Once the pull request is ready, I'll request review from you. |
Member
|
all works well, before merging, let's discuss if the implementation is exactly the one we want to use or not.
|
Member
FerriolCalvet
left a comment
There was a problem hiding this comment.
functionally tested, but missing to agree on the details of the multiple testing correction
Member
|
Assuming it is a float32 numeric type, we can use 1.17*10^{-38} as the minimum possible non-zero p-value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omega results need independent multiple-testing correction across cohort, group, and per-sample comparisons, applied separately at gene and subgenic levels, for both omega and omegagloballoc outputs.
Multiple-testing correction pipeline
omega_multiple_testing.pyto apply BH correction per{all_samples|group|sample} × {gene|subgenic}slice and emitpvalue_adj.OMEGA_MULTITESTruns the correction and replaces compiled omega outputs for both omega and omegagloballoc.Workflow wiring + outputs
OMEGA_ANALYSISsoall_omegas*.tsvandall_omegas*_global_loc.tsvare corrected before publish.Tests/docs
pvalue_adj.Example correction behavior (BH per slice):