Group member label support#850
Open
Berglund wants to merge 2 commits into
Open
Conversation
Berglund
force-pushed
the
group-member-label-support
branch
from
0938262 to
26ca5fa
Compare
bbernhard
reviewed
May 25, 2026
| Description *string `json:"description,omitempty"` | ||
| Name *string `json:"name,omitempty"` | ||
| MemberLabel *string `json:"member_label,omitempty"` | ||
| MemberLabelEmoji *string `json:"member_label_emoji,omitempty"` |
Owner
There was a problem hiding this comment.
Thanks a lot for the PR!
In general I think the PR is fine. What I am unsure though is, the structure of the public interface. I think I'd prefer some like:
MemberLabel struct {
Name *string `json:"name,omitempty"
Emoji *string `json:"emoji,omitempty"`
} `json:"member_label,omitempty"`
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a use-case for the new label (and emoji) feature in groups, and noted that
signal-clihad support (AsamK/signal-cli@27a722d) but notsignal-cli-rest-api.If unaware of this functionality, it allows you to set a label for yourself in a group that's then visible for others:
This PR has two commits;
f07c587 adds support for setting the label via
PUT/v1/groups/<number>/<group id>withmember_labelandmember_label_emoji.0938262 exposes the labels set in various groups on
GET/v1/groups/<number>