This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Improve check for paths as Hashes in CaptureOptions#582
Open
stevenday wants to merge 2 commits intobbc:masterfrom
Open
Improve check for paths as Hashes in CaptureOptions#582stevenday wants to merge 2 commits intobbc:masterfrom
stevenday wants to merge 2 commits intobbc:masterfrom
Conversation
Author
|
I just noticed that a related bug was present in the GalleryGenerator too, so I've added a fix for that in 0c39b03. The code duplication suggests that the GalleryGenerator should use the CaptureOptions to parse the options, but I didn't want to make such a big change here just to fix this small bug. |
To match the changes to CaptureOptions. For bbc#536
stevenday
force-pushed
the
issues/536-path-in-paths
branch
from
0c39b03 to
c90ee53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the awesome project!
This is my first PR and my Ruby is a little bit rusty, so please excuse any idiosyncrasies! I'm also running windows locally so I couldn't get the whole dev environment up and running to test everything before pushing, but I'll fix up whatever Travis finds.
Without knowing a whole lot about how this was supposed to be working, hopefully I've captured the intent of the code a bit better and fixed the issue reported in #536 at the same time.
I went for options.fetch so that it raised a KeyError, because I figured it'd make it more obvious that you're supposed to provide a
pathkey if your path is a hash, rather than silently returning nil.Fixes #536 and #466