Add proposal for support for init segments in Flows#167
Conversation
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
893daf0 to
7689cf9
Compare
j616
force-pushed
the
jamessa-flowInitSegments
branch
2 times, most recently
from
d0d74d8 to
27d82aa
Compare
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
cec3208 to
87f693d
Compare
sem-ver: feature
While `video/mp4` is sometimes used, `video/iso.segment` is strictly speaking correct.
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
87f693d to
b3b3ac6
Compare
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
e6f66ac to
7d93a5b
Compare
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
7d93a5b to
02a5555
Compare
samdbmg
left a comment
samdbmg
left a comment
There was a problem hiding this comment.
Overall changes make sense and look good. Requesting changes because the examples don't match the schema (although I've inlined a question about the schema).
Also, should we call out around DELETE /flows/<flowid>/segments that you should hang on to init segment objects that are referenced by media objects, and delete them when no longer referenced, same as for media objects referenced by Flows?
| "default": false | ||
| }, | ||
| "init_segments": { | ||
| "description": "Whether the Flow makes use of initialisation segments. This parameter MUST be set to `true` if Media Objects have `init_object` populated. If set to `true`, all Media Objects MUST have `init_object` populated. Assume `false` if omitted.", |
There was a problem hiding this comment.
Thoughts on whether this should be a Flow property? Since it's kinda an artifact of how the container and splitting into objects works (and lines up with the Flow GET example in this PR, which seems neater IMO)
There was a problem hiding this comment.
I've partly placed this here due to how the Profiles proposal has been architected. I think it would need to be at this level to allow the profile to match on this property which has a significant role in compatibility of media.
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
ef5d6cf to
ff75229
Compare
j616
force-pushed
the
jamessa-flowInitSegments
branch
from
ff75229 to
ced27ab
Compare
@samdbmg I've added a note to here and DELETE /flows/. It seems that while we've implied the need for reference counting in the past, we haven't ever called it out against these methods. |
3 participants
Details
Support for init Segments in Flows
Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5501
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.