WS-2706: Adds world cup team name translations#14077
Draft
Isabella-Mitchell wants to merge 11 commits into
Draft
WS-2706: Adds world cup team name translations#14077Isabella-Mitchell wants to merge 11 commits into
Isabella-Mitchell wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2706
Summary
Translates the rendered country team name. E.g.
England vs Germanyon Afrique becomesAngleterre vs Allemagne// to do - this PR currently only translates the names in the Team component, still scoping out the best way to translate in all places where the name is rendered
Code changes
Provided translations for all services excluding:
archive.ts
cymrufyw.ts
naidheachdan.ts
news.ts
newsround.ts
scotland.ts
sport.ts
ukchina.ts
ws.ts
Testing
1.See http://localhost:7081/arabic/live/ckq1ll8qlmdmt?renderer_env=test - morocco are in the world cup so the name is translated. Burundi is not, so the name falls back to English
Useful Links