mdbook: fix support for external repositories#4027
Open
mgeisler wants to merge 1 commit into
Open
Conversation
When any part of an mdbook target (either the book.toml or the source files) comes from an external repository, the build was failing because the rule's staging logic and its invocation logic handled repository boundaries inconsistently. This change: - Updates _map_inputs in mdbook.bzl to map external repository paths to 'external/' instead of '../'. - Hardens the process wrapper with a bounds check to ensure files are not staged outside the shadow work directory. - Adds an integration test to verify the fix and prevent regressions.
Contributor
Author
Please note that I don't know what the idiomatic way to handle such things are. Gemini came up with this and it seems to work based on its new test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When any part of an
mdbooktarget (either thebook.tomlor the source files) comes from an external repository, the build was failing because the rule's staging logic and its invocation logic handled repository boundaries inconsistently.This change:
_map_inputsinmdbook.bzlto map external repository paths to'external/'instead of'../'.Made by Gemini, fixes #4026.