fix collect coverage script to work with recent changes#3812
Open
anonrig wants to merge 1 commit intobazelbuild:mainfrom
Open
fix collect coverage script to work with recent changes#3812anonrig wants to merge 1 commit intobazelbuild:mainfrom
anonrig wants to merge 1 commit intobazelbuild:mainfrom
Conversation
anonrig
force-pushed
the
yagiz/fix-collect_coverage
branch
2 times, most recently
from
8df50f7 to
335b9ee
Compare
In Bazel 8+, RUNFILES_DIR may not be set during coverage post-processing. This change: - Makes RUNFILES_DIR optional, with fallback to BAZEL_COVERAGE_INTERNAL_RUNFILES_DIR - Derives the bindir from COVERAGE_DIR when runfiles is unavailable - Simplifies the test binary lookup logic
anonrig
force-pushed
the
yagiz/fix-collect_coverage
branch
from
335b9ee to
cb9d412
Compare
Collaborator
|
Sorry for the delay in getting to this! I can't find any mention of Also it looks like CI is currently failing due to a hopefully-trivial-to-fix clippy issue :) |
|
FWIW In Bazel 9, we also have to set |
illicitonion
added
coverage
expert-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure RUNFILES_DIR also tries BAZEL_COVERAGE_INTERNAL_RUNFILES_DIR. This change ensures that we don't throw a fatal error and exit due to RUNFILES_DIR being empty.
In bazel 8, coverage collection script clears RUNFILES_DIR before calling language specific coverage collectors. The rules_rust collect_coverage tool was panicking because it required RUNFILES_DIR to be set.