Allow filtering instrumented classes in JacocoInstrumentationProcessor#29502
Open
Steffeeen wants to merge 1 commit into
Open
Allow filtering instrumented classes in JacocoInstrumentationProcessor#29502Steffeeen wants to merge 1 commit into
Steffeeen wants to merge 1 commit into
Conversation
The filtering mechanism is the same as used by JaCoCo. All classes that are specified in include are instrumented except if they are in exclude. The matching engine allows using `?` to match any single character and `*` to match any number of any character. These are the same wildcards as supported by JaCoCo.
github-actions
Bot
added
team-Rules-Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows passing include and exclude lists to the
JacocoInstrumentationProcessorto filter which classes get instrumented. The format and behavior is the same as used by JaCoCo. Only classes in the include list get instrumented except if they are in the exclude list. The lists are lists of class names separated by:. The class names use/as a separator instead of..?and*are supported as wildcards. If no options are given all classes will be included (again matching the behavior of JaCoCo).Should I add tests for these changes? That would require refactoring the code a bit and moving the include/exclude logic into a separate method or class.
Motivation
Fixes #28209 and #21520 in combination with bazelbuild/rules_java#356
Build API Changes
No
Checklist
Release Notes