[9.1.0] Use a virtual thread executor for the disk cache (https://github.com/bazelbuild/bazel/pull/28430)#28464
Merged
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from Jan 29, 2026
Conversation
Individual disk cache operations are I/O-bound and not related to `--jobs` or remotely executing actions in any direct way, so it doesn't make sense to reuse the remote `ExecutorService` for them. Closes bazelbuild#28430. PiperOrigin-RevId: 862134357 Change-Id: I8e6c43649443179b9d73735a206fad04591fad2a
bazel-io
added
team-Remote-Exec
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the DiskCacheClient to use its own virtual thread-based executor. This is a great improvement, as disk cache operations are I/O-bound and well-suited for virtual threads. This change correctly decouples the disk cache's threading model from the remote execution executor, simplifying the code paths that construct the DiskCacheClient. The addition of a close() method to DiskCacheClient and ensuring its cleanup in tests and production code is correctly handled. The changes are clean and improve both architecture and performance. I have not found any issues.
coeuvre
approved these changes
Jan 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
bazelbuild:release-9.1.0
with commit Jan 29, 2026
7480998
46 checks passed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual disk cache operations are I/O-bound and not related to
--jobsor remotely executing actions in any direct way, so it doesn't make sense to reuse the remoteExecutorServicefor them.Closes #28430.
PiperOrigin-RevId: 862134357
Change-Id: I8e6c43649443179b9d73735a206fad04591fad2a
Commit 81a74d2