Fixed condition when numBins is in string format, added minimum and maximum input parameters for calculateHistogram #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baus
reviewed
Aug 8, 2021
| var binIndex = Math.floor((item - min) / binSize); | ||
| // for values that lie exactly on last bin we need to subtract one | ||
| if (binIndex === numBins) { | ||
| if (binIndex === numBins || JSON.stringify(binIndex) === numBins) { |
Owner
There was a problem hiding this comment.
@fdpamb I'm just getting around the updating this module. Thanks for the suggestions. I don't think I will merge this change, as I consider it to be responsibility of the module to handle parameters in multiple types. The user can easily convert this a number prior to calling the function
baus
reviewed
Aug 8, 2021
| let binIndex = Math.floor((item - min) / binSize); | ||
| // for values that lie exactly on last bin we need to subtract one | ||
| if (binIndex === numBins) { | ||
| if (binIndex === numBins || JSON.stringify(binIndex) === numBins) { |
Owner
There was a problem hiding this comment.
Same comment as above. I don't think it is the module's responsibility to accept parameters of multiple types. The user can easily convert to correct type prior to calling the module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.