-
Notifications
You must be signed in to change notification settings - Fork 659
Adding XRoar Emulator for Tandy Color Computer emulation #14992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
when working on a PR, mark it as draft until you have finished. also squash your commits so it's 1 commit, not currently 9. |
Add xroar emulator for arm64 and x86_64
|
I have squashed the commits now. This is my first contribution for this project so forgive my ignorance. What else is required for this to be merged? It has worked in my testing and I'm not planning to override the default of MAME so it should have little impact to any users not actively seeking it. |
dmanlfc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there no configuration features whatsoever required?
package/batocera/core/batocera-configgen/configgen/configgen/generators/xroar/xroarGenerator.py
Show resolved
Hide resolved
| from typing import TYPE_CHECKING | ||
|
|
||
| from ... import Command | ||
| from ...controller import generate_sdl_game_controller_config, write_sdl_controller_db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't use these...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do controllers work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.6809.org.uk/xroar/doc/xroar.shtml#Joysticks
Seems via SDL2, worked out of the box for me
Wait this interesting
https://www.6809.org.uk/xroar/doc/xroar.shtml#Joystick-options
You can indeed map a file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be using SDL controllers, I believe that's what was making it work on my rg35xxh. Are you saying that line 6 can be removed and it would still work the same if there wasn't another export command in my script?
| XROAR_CONF_OPTS += --enable-coco3 | ||
| XROAR_CONF_OPTS += --enable-mc10 | ||
| XROAR_CONF_OPTS += --without-gtk2 | ||
| XROAR_CONF_OPTS += --without-gtk3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not gtk3 & gtkgl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the parameters I used for most compatibility in testing when I built it for portmaster and aarch64, and it also runs this way for x86_64 devices
| select BR2_PACKAGE_LIBCAPSIMAGE # ALL | ||
|
|
||
| # Color Computer (Tandy TRS-80) | ||
| select BR2_PACKAGE_XROAR # ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it low cpu requirements and therefore can likely work on all supported systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reference machine for running this has been an h700 arm device. It may not work on armhf, what is needed to mark that as excluded, or how would that get tested?
This is my first effort with something like buildroot so I will accept any pointers and tips.
This compiles on x86_64 and aarch64 and I was able to open and run a joystick game on both platforms.
It will need unzipped bios files bas13.rom and extbas11.rom in /userdata/bios/