Skip to content

Conversation

@discretizer
Copy link

@discretizer discretizer commented Jul 28, 2025

This PR adds support for the broadcom-wl driver. By default it is disabled but can be enabled by modfiying the driver blacklist files like so:

mv /etc/modprobe.d/blacklist-wl.conf to /etc/modprobe.d/blacklist-wl.conf.disabled
mv /etc/modprobe.d/macbook-wifi.conf.disabled /etc/modprobe.d/macbook-wifi.conf
batocera-save-overlay

Additionally to get things to work a patch to wpa_supplicant is needed. The patch in this PR is taken from the following wpa_supplicant development thread:

https://lists.infradead.org/pipermail/hostap/2025-May/043475.html

This should fix an issue with the broadcom wl driver where AP scans don't work. This is a combination of two separate patches that are already in the upstream git repo, but not in the released version.

This PR resolves the following issue:
#7894

And replaces the older PR here:
#7735

To revert these changes just reverse the above renames
Tested on a Macmini7,1

Add patches for later kernel versions

Add patch for 6.15 kernel

Commit last fix
@discretizer
Copy link
Author

I kinda wish there was a better way to do some of these enabling steps. I've simplified this as much as possible. If anyone has any thoughts let me know - or just point me to some documentation I can update to add these steps.

I think the wpa_supplicant step was primarily what was missing from the earlier PR.

@dmanlfc
Copy link
Collaborator

dmanlfc commented Jul 28, 2025

This was confirmed as not working by multiple Mac users. I don't see what's changed...

@discretizer

This comment was marked as outdated.

@discretizer

This comment was marked as outdated.

@discretizer
Copy link
Author

If there's a better way to handle this configuration quirk let me know. I'm fine if the eventual answer is "will not merge" (the driver is ancient anyway), I just want to get some documentation out there for how to make this work.

@discretizer
Copy link
Author

discretizer commented Jul 29, 2025

Ok... there was ANOTHER wpa_supplicant bug. I made a PR into the buildroot repo to fix that one:

batocera-linux/buildroot#1054

@dmanlfc
Copy link
Collaborator

dmanlfc commented Jul 29, 2025

The dbus change cannot be added as is. It will affect all users. Also we don't use systemd.

@discretizer
Copy link
Author

discretizer commented Jul 29, 2025

The dbus change cannot be added as is. It will affect all users. Also we don't use systemd.

DBus change is not needed anymore with the wpa_supplicant PR and nothing in this PR should affect or depend on systemd.

@dmanlfc
Copy link
Collaborator

dmanlfc commented Jul 29, 2025

The previous dbus change referenced systemd.
The patch may be ok, I will need to read it in more detail.
Where is the source of this patch? So I can read more about it.

@discretizer
Copy link
Author

Moved the wpa_supplicant patch here in proper location per your comment on the buildroot PR (batocera-linux/buildroot#1054) and closed that PR. Patch originates from wpa_supplicant development thread here:
https://lists.infradead.org/pipermail/hostap/2025-May/043475.html

Reverted build root changes in branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

43 Batocera 43

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants