Skip to content

Use set-backed tracking for faster duplicate argument checks #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stephen0512 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use set-backed tracking for faster duplicate argument checks #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions boolean/boolean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,28 +1340,32 @@ def simplify(self, sort=True):
# (A | B) | C = A | (B | C) = A | B | C
expr = expr.flatten()

# Remove duplicates while preserving order.
seen = set()
args = []
for arg in expr.args:
if arg not in seen:
seen.add(arg)
args.append(arg)

# Annihilation: A & 0 = 0, A | 1 = 1
if self.annihilator in expr.args:
if self.annihilator in seen:
return self.annihilator

# Idempotence: A & A = A, A | A = A
# this boils down to removing duplicates
args = []
for arg in expr.args:
if arg not in args:
args.append(arg)
if len(args) == 1:
return args[0]

# Identity: A & 1 = A, A | 0 = A
if self.identity in args:
if self.identity in seen:
args.remove(self.identity)
seen.remove(self.identity)
if len(args) == 1:
return args[0]

# Complementation: A & ~A = 0, A | ~A = 1
for arg in args:
if self.NOT(arg) in args:
if self.NOT(arg) in seen:
return self.annihilator

# Elimination: (A & B) | (A & ~B) = A, (A | B) & (A | ~B) = A
Expand Down