Skip to content

Fix string start with number issue #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jma1987 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix string start with number issue #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e68aa28
fix string start with number issue
Mar 27, 2018
a4bcc7b
Update package.json
jma1987 Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,16 @@ function maybeIsNumber(n) {
if (n instanceof Long) {
return n;
}
var asNum = parseFloat(n);
if (isNaN(asNum)) {
return undefined;
var regPos = /^\d+(\.\d+)?$/; //Float number
var regNeg = /^(-(([0-9]+\.[0-9]*[1-9][0-9]*)|([0-9]*[1-9][0-9]*\.[0-9]+)|([0-9]*[1-9][0-9]*)))$/;//Float number below zero
if (regPos.test(n) || regNeg.test(n)) {
var asNum = parseFloat(n);
if (isNaN(asNum)) {
return undefined;
}
return asNum;
}
return asNum;
return n;
}

function isInteger(n) {
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "basho-riak-client",
"name": "basho-riak-client-covs",
"description": "Basho's officially supported NodeJS client for Riak",
"version": "2.4.0",
"version": "2.4.1-alpha1",
"author": "Brian Roach <roach@basho.com>",
"contributors": [
"Luke Bakken <luke@bakken.io>",
Expand Down