fix: Stable channel update uses tagged release #5948#5950
Open
jcontonio wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds “stable channel” behavior to omarchy-update-git so updates land on the latest non–pre-release GitHub release tag instead of the current master tip, and introduces a test to validate that behavior.
Changes:
- Update
bin/omarchy-update-gitto detect the version channel and, forstable, checkout the latest non–pre-release release tag. - Add an integration-style shell test that builds a local repo with a stable tag and a newer pre-release on
master, then asserts stable selects the tag.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/omarchy-update-git-test.sh | New test to verify stable channel checks out the latest non–pre-release release tag vs master. |
| bin/omarchy-update-git | Implements “stable channel uses latest release tag” logic using gh release list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| TMPDIR=$(mktemp -d) | ||
|
|
||
| latest_tag=$(gh release list --repo basecamp/omarchy --exclude-pre-releases --limit 1 --json tagName --jq '.[0].tagName') |
Comment on lines
+38
to
+40
| git -C "$SEED" commit --allow-empty -m "$latest_tag" -q | ||
| git -C "$SEED" tag "$latest_tag" | ||
| git -C "$SEED" commit --allow-empty -m "pre-release on master" -q |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
bin/omarchy-update-gitto use the latest non-pre-release GitHub release for the stable channel instead of pulling from the tip of master.Before
The stable channel update pulled from master, meaning any commit pushed to master (including pre-release code) would be delivered to stable users. Running a stable-channel update jumped me from 3.8.0 to 4.0.0alpha!
After
The stable channel now queries GitHub for the latest non-pre-release release and checks out that tag. The rc, edge, and dev channels are unchanged.
To test
Closes #5948