fix: Detect internal laptop displays more broadly#5907
Open
jobenaus wants to merge 125 commits into
Open
Conversation
Omarchy 3.5.0
Omarchy 3.8.0
GitHub's default branch on basecamp/omarchy is no longer master, so a plain clone pulls the development branch. Pass --branch master so reinstalls always land on stable regardless of repo default.
…ult-branch Pin omarchy-reinstall-git to master branch
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jobenaus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5906.
This broadens internal laptop display detection from only
eDPto common internal connector names:eDPLVDSDSIWhy
Some older laptops expose their built-in panel as
LVDS-1. Previously:omarchy-hw-external-monitorsonly ignoredeDP-*, soLVDS-1was treated as an external monitor.omarchy-hyprland-monitor-internalonly selected monitors containingeDP, so it could fail to find the laptop panel.That combination can make the lid-switch binding attempt to disable the only active display.
Changes
INTERNAL_MONITOR_MATCHESlist.omarchy-hw-external-monitorsto skip internal display connectors.omarchy-hyprland-monitor-internalto find the laptop panel.Tested
On a laptop with internal display
LVDS-1:hyprctl monitorsdetectsLVDS-1.omarchy-hw-external-monitorsreturns non-zero when no external display is connected.