Account for keyboard layout variant for keybinding helper#5881
Open
blegat wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
omarchy menu keybindings, I see the wrong keys for expanding and shrinking windows. This is becausekbcli compile-keymapis called without any--layoutnor--variantflag so it defaults to US/qwerty even though mykb_layoutisbe.So
xkbcli compile-keymapgivesAE11=minus, AE12=equalandxkbcli compile-keymap --layout begivesAE11=parenright, AE12=minus.The change in the output of
omarchy menu keybindingswith this PR is as follows:SUPER + minus → Expand window leftSUPER + parenright → Expand window leftSUPER + equal → Shrink window leftSUPER + minus → Shrink window leftSUPER SHIFT + minus → Shrink window upSUPER SHIFT + parenright → Shrink window upSUPER SHIFT + equal → Expand window downSUPER SHIFT + minus → Expand window downCloses #4188
Closes #734