Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces Fizzy’s supported beta deploy environments from four down to one by removing the extra beta deploy entrypoints and trimming the beta environment mapping in the shared deploy template.
Changes:
- Deleted the
deploy.beta2.yml,deploy.beta3.yml, anddeploy.beta4.ymlenvironment entrypoint files. - Removed the beta2–beta4 host/db mappings from
saas/config/deploy.beta.yml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
saas/config/deploy.beta.yml |
Removes beta2–beta4 environment definitions from the shared beta deploy template. |
saas/config/deploy.beta2.yml |
Deletes beta2 deploy entrypoint. |
saas/config/deploy.beta3.yml |
Deletes beta3 deploy entrypoint. |
saas/config/deploy.beta4.yml |
Deletes beta4 deploy entrypoint. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Comments suppressed due to low confidence (1)
saas/config/deploy.beta.yml:17
@datanow includes an extra top-level key ("dbs") with asolidqueuehost ending in-104. This makes the@data[@beta_number]validation incorrect (e.g.,BETA_NUMBER=dbswould pass the check and then fail later), and it also leaves a stale beta4 reference in what should be the single remaining beta config. Remove this stray entry and ensure@dataonly contains the intended beta(s) with consistent host/db mappings.
},
"dbs" => {
"solidqueue" => "fizzy-beta-solidqueue-db-104.df-iad-int.37signals.com"
}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
saas/config/deploy.beta.yml
Outdated
| "solidqueue" => "fizzy-beta-solidqueue-db-101.df-iad-int.37signals.com" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Pull request overview
This PR reduces Fizzy’s beta footprint by removing support/configuration for beta environments 2–4, leaving only beta1 as the active/maintained beta environment.
Changes:
- Remove load balancer configuration steps for beta2–beta4.
- Delete Kamal deploy config entrypoints for beta2–beta4 and remove their host mappings.
- Update SaaS README to reflect a single beta environment and simplified deploy instructions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
saas/script/configure-lb-beta.sh |
Removes beta2–beta4 LB deployment steps, leaving only beta1. |
saas/config/deploy.beta4.yml |
Deletes beta4 deploy entrypoint config. |
saas/config/deploy.beta3.yml |
Deletes beta3 deploy entrypoint config. |
saas/config/deploy.beta2.yml |
Deletes beta2 deploy entrypoint config. |
saas/config/deploy.beta.yml |
Removes beta2–beta4 host/db mappings so only beta1 is defined. |
saas/README.md |
Updates documentation to list only beta1 and its deploy command. |
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
saas/README.md
Outdated
| There is 1 beta environments: | ||
|
|
||
| - https://beta1.fizzy-beta.com | ||
| - https://beta2.fizzy-beta.com | ||
| - https://beta3.fizzy-beta.com | ||
| - https://beta4.fizzy-beta.com | ||
|
|
||
| Deploy with: `bin/kamal deploy -d beta1` (or `-d beta2`, `-d beta3`, `-d beta4`) | ||
| Deploy with: `bin/kamal deploy -d beta1` |
This PR aims to reduce the amount of available beta environments from 4 to 1.
Related: https://app.3.basecamp.com/2914079/buckets/21350690/card_tables/cards/9680902611