-
Notifications
You must be signed in to change notification settings - Fork 6
BC5 readiness: forward-compat spec, briefs, parity lint #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeremy
wants to merge
11
commits into
main
Choose a base branch
from
bc5-readiness-spec-foundations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
603f1ee
spec(bc5): forward-compat additions + parallel BC4/BC5 provenance
jeremy aefc5b3
build(make): add generate aggregator, parity lint, branch-aware sync-…
jeremy 93658a2
docs(api-gaps): API gap registry + SDK↔BC3 coordination + validator
jeremy 5b3b86e
ts: regenerate from BC5 spec additions
jeremy 62dabbb
ruby: regenerate from BC5 spec additions
jeremy 2bf592d
python: regenerate from BC5 spec additions
jeremy 899f4be
kotlin: regenerate from BC5 spec additions
jeremy db97beb
swift: regenerate from BC5 spec additions
jeremy 7e9c434
go: regenerate from BC5 spec additions
jeremy 2d65b0d
typescript: pin fast-uri and brace-expansion via overrides
jeremy 6d6d16f
spec: address Copilot review threads on bucket-parity lint + brief
jeremy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # Coordination: SDK ↔ BC3 API Parity for BC5 | ||
|
|
||
| This SDK works in lockstep with the BC3 API parity plan, tracked on the | ||
| `basecamp/bc3` `five+api` branch. The authoritative server-side audit lives | ||
| in that branch under `tmp/api_audit.md` (generated by the BC3 plan's | ||
| `script/api/audit`). | ||
|
|
||
| ## Division of labor | ||
|
|
||
| - **BC3 plan owns**: server-side audit, jbuilder + controller + doc | ||
| additions, BC4 compat verification, regenerating live-server doc | ||
| snapshots, eventually opening Smithy PRs in this repo. | ||
| - **This SDK plan owns**: live canary against both backends, schema + | ||
| pairwise validation on raw wire bytes, additive Smithy absorption per | ||
| BC3 deliverable, the API-gap detector that catches anything BC3 hasn't | ||
| registered, the bucket-flat parity lint, the API gap registry at | ||
| [`spec/api-gaps/`](spec/api-gaps/). | ||
|
|
||
| ## Lifecycle per gap | ||
|
|
||
| 1. BC3 plan inventories a gap (Phase 1 audit) → SDK adds a corresponding | ||
| entry in [`spec/api-gaps/`](spec/api-gaps/). | ||
| 2. BC3 ships the JSON API for the gap → SDK canary auto-detects new | ||
| fields/endpoints. | ||
| 3. SDK opens a Smithy + per-language regeneration PR absorbing the new | ||
| contract. | ||
| 4. Entry frontmatter updates: `status: addressed-in-bc3-pr-N` then | ||
| `status: absorbed-in-sdk` with Smithy refs. | ||
|
|
||
| ## Contract decisions (cross-team) | ||
|
|
||
| Two items the SDK canary surfaced that need product/API leadership decisions: | ||
|
|
||
| 1. `memories` going to `[]` on `GET /my/readings.json` — back-compat or | ||
| accept-and-document. BC4 populates the array; BC5 emits literal `[]`. | ||
| Existing BC4 API users reading `memories` would silently see no data on | ||
| BC5 — a subtractive change disguised as compatible. | ||
| 2. Longstanding `app_todoslists_url` typo at | ||
| `app/views/api/todosets/_todoset.json.jbuilder:28` — server fix, alias | ||
| period, or SDK accommodation. The SDK spec models the correctly-spelled | ||
| `app_todolists_url`, so SDK clients reading that field have always seen | ||
| `null`. | ||
|
|
||
| Both are tracked in the BC3 plan's Phase 2 compat verification and this | ||
| SDK plan's §8. | ||
|
|
||
| ## Where to look | ||
|
|
||
| - BC3-side authoritative inventory: `tmp/api_audit.md` (generated by BC3 | ||
| plan's `script/api/audit`) | ||
| - SDK-side absorption status: [`spec/api-gaps/README.md`](spec/api-gaps/README.md) | ||
| - Live canary results: `make check-bc5-compat` against current refs | ||
| (lands in PR 4 of the SDK plan) | ||
| - Cross-team alignment status: this file | ||
|
|
||
| — The basecamp-sdk team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2597,6 +2597,7 @@ | |
| "$.email_address", | ||
| "$.title", | ||
| "$.bio", | ||
| "$.tagline", | ||
| "$.location", | ||
| "$.avatar_url" | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,14 @@ | ||
| { | ||
| "bc3": { | ||
| "revision": "056a356ee0d3b018362adbc8b44703df0567adbf", | ||
| "date": "2026-03-23" | ||
| "branch": "five", | ||
| "revision": "a790dc09461d8729a7d4f6d875476581f59f3b40", | ||
| "date": "2026-05-01" | ||
| }, | ||
| "compatibility": { | ||
| "bc3-master": { | ||
| "branch": "master", | ||
| "revision": "f2450b7a1ac6a52b672975021c7c327cecc51852", | ||
| "date": "2026-05-01" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.