Skip to content

fix: the code constructs file paths using string con... in... #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

fix: the code constructs file paths using string con... in... #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions dependency_updater/dependency_updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"log"
"os"
"os/exec"
"path/filepath"
"strings"
)

Expand Down Expand Up @@ -82,7 +83,12 @@ func updater(token string, repoPath string, commit bool, githubAction bool) erro
var dependencies Dependencies
var updatedDependencies []VersionUpdateInfo

f, err := os.ReadFile(repoPath + "/versions.json")
repoPath, err = filepath.Abs(repoPath)
if err != nil {
return fmt.Errorf("error resolving repo path: %s", err)
}

f, err := os.ReadFile(filepath.Join(repoPath, "versions.json"))
if err != nil {
return fmt.Errorf("error reading versions JSON: %s", err)
}
Expand Down Expand Up @@ -336,7 +342,7 @@ func writeToVersionsJson(repoPath string, dependencies Dependencies) error {
return fmt.Errorf("error marshaling dependencies json: %s", err)
}

e := os.WriteFile(repoPath+"/versions.json", updatedJson, 0644)
e := os.WriteFile(filepath.Join(repoPath, "versions.json"), updatedJson, 0644)
if e != nil {
return fmt.Errorf("error writing to versions.json: %s", e)
}
Expand Down Expand Up @@ -368,7 +374,7 @@ func createVersionsEnv(repoPath string, dependencies Dependencies) error {

slices.Sort(envLines)

file, err := os.Create(repoPath + "/versions.env")
file, err := os.Create(filepath.Join(repoPath, "versions.env"))
if err != nil {
return fmt.Errorf("error creating versions.env file: %s", err)
}
Expand Down