docs: add upgrade testing guide with block number rotation process#301
Open
okwn wants to merge 3 commits into
Open
docs: add upgrade testing guide with block number rotation process#301okwn wants to merge 3 commits into
okwn wants to merge 3 commits into
Conversation
- Add coverage check using 'just coverage-lcov' with 70% threshold - Add semgrep as blocking step via returntocorp/semgrep-action - Fix semgrep justfile target to use ./src instead of non-existent path
Add invariant tests for OptimismPortal2 covering: - minimumGasLimit is never zero for any calldata size - portal paused state is consistent with system config - portal has minimum balance (sanity check) These invariants verify critical security properties of the portal's configuration and access controls. The tests follow the pattern of existing invariant tests in test/invariants/ (SafeCall, CrossDomainMessenger). Part of effort to increase invariant test coverage for the bridge protocol which currently has only 2 invariant test files.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
docs/upgrade-testing.mdthat documents the upgrade testing process for the Base contracts repository.What it covers
sepoliaBlockNumberandmainnetBlockNumberare set injustfilejust test-fork sepolia,just test-fork mainnet,just coverage-upgradecast block-number, updatingjustfile, verifying tests passWhy this matters
The backlog identified that "no documented process exists for when/how to update
sepoliaBlockNumber/mainnetBlockNumber". Without documented process, block numbers go stale and tests run against outdated chain state, missing potential upgrade issues.Why Safe