Skip to content

chore: simplify proof tests#297

Merged
jackchuma merged 6 commits into
mainfrom
chore/simplify-proof-tests
May 21, 2026
Merged

chore: simplify proof tests#297
jackchuma merged 6 commits into
mainfrom
chore/simplify-proof-tests

Conversation

@jackchuma
Copy link
Copy Markdown
Contributor

@jackchuma jackchuma commented May 20, 2026

Simplifies and consolidates the L1 proof test suite.

Changes

  • Reduces test file sizes significantly (~1000 lines removed)
  • Standardizes visibility modifiers (publicinternal) for test fixtures
  • Removes unused imports and dead code
  • Bumps pragma to ^0.8.15 for consistency
  • Tightens up test setup and helpers across all proof test files

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 20, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Comment thread test/L1/proofs/Nullify.t.sol Outdated
@jackchuma jackchuma requested a review from xenoliss May 21, 2026 14:05
@jackchuma jackchuma merged commit 0fcc0e5 into main May 21, 2026
6 checks passed
@jackchuma jackchuma deleted the chore/simplify-proof-tests branch May 21, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants