-
Notifications
You must be signed in to change notification settings - Fork 0
Feature templates #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
===========================================
+ Coverage 58.75% 78.45% +19.70%
===========================================
Files 17 35 +18
Lines 320 1193 +873
===========================================
+ Hits 188 936 +748
- Misses 132 257 +125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
At this point, tests are passing for user defined templates, including tests which run a simulation and compare cross sections parsed from the output to expected values. See It should be fairly simple to copy and modify this test file to apply to a new test suite. We need test suites for problems with the template types that can be generated in bfrescox:
There is an additional remaining task:
|
|
Also, we could probably simplify testing with https://docs.python.org/3/library/tempfile.html |
|
Final self review:
|
|
Will this PR be addressed before bandframework/bandframework#181 ? |
v0.0.1-alpha is based on this branch, not main. This can be merged into main after v0.5 release. |
|
I suggest deleting all of the DS_Store files. Also, in v0.0.1-alpha, |
Pending PR tasks
bfrescoxtests passing. Please document and justify all test design decisions inTestData/README(e.g., adjusting threshold test value)bfrescoxprotesting to run the same tests asbfrescoxchecktox task)PR Self-review
bfrescoxand confirm that contents are correct and minimal.@jared321 PR Review
bfrescoxpro, on a variety of different machines with modules and different MPI implementationsmain