jenkins_build.sh: upload .bmap files to s3 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix some whitespaces while here Signed-off-by: Michal Mazurek <michal@resin.io>
Contributor
Author
|
Will COMPRESSED or ARCHIVE invalidate the usefulness of a .bmap file? When are these options used? Can they be removed? readlink --canonicalize seems to be GNU-only, but I think that's fine. connect balena-os/balena-beaglebone#71 |
Contributor
Author
|
connect balena-os/balena-os#163 |
floion
previously approved these changes
Feb 23, 2017
Contributor
|
Needs rebasing but looks good. |
|
ping @jhermsmeier since I guess this would be useful for Etcher too? |
kaisoz
added
the
versionbot/pr-draft
ghost
dismissed
Contributor
|
@michal-mazurek @floion Shall we close this? It looks like an old piece of work. Otherwise please unsign me as a reviewer. |
telphan
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some whitespaces while here