fix(collector): string device references have not been replaced in parent scenarios/setups#152
Merged
matosys merged 3 commits intobalder-dev:mainfrom Apr 28, 2026
Conversation
… within parent scenario
…thin parent setup
…rent scenarios/setups iterate over all parent scenarios and setup classes in method `Collector._exchange_strings_with_objects()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the collector failed to correctly determine connections between devices in parent scenario or setup classes. The bug occurred when the
@balder.connect(...)decorator witihin the parent scenario/setup used string references to specify the devices.The fix updates the implementation in
Collector._exchange_strings_with_objects()so that it now properly considers all relevant parent scenario and setup classes during string-to-object replacement.