Reextracting tickers, sqlalchemy, reading_bot #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgangt
approved these changes
Jan 20, 2021
Collaborator
morgangt
left a comment
morgangt
left a comment
There was a problem hiding this comment.
В целом хороший рефакторинг
| class BotUser(Base): | ||
| __tablename__ = "bot_user" | ||
| id = Column(Integer, primary_key=True) | ||
| username = Column(String(50)) |
Collaborator
There was a problem hiding this comment.
предлагаю добавить поле дата добавления (дата регистрации) и дату последнего сообщения - но это не обязательно, так как её можно достать из чата
| def send_news(self): | ||
| users = BotUser.query.all() | ||
| for user in users: | ||
| self.send_message(chat_id=user.id, text=self.message, parse_mode=ParseMode.HTML) |
Collaborator
There was a problem hiding this comment.
предлагаю подумать о том чтобы добавить проверку на отправку сообщений одному пользователю - когда последний раз отправляли сообщение. чтобы не спамить user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Переимпортированы тикеры
Переделана работа с flask-sqlalchemy на sqlalchemy
Реализован прослушивающий новых пользователей бот, который из записывает в базу данных
Рассылающий бот рассылает новости тоько пользователям из базы данных