-
Notifications
You must be signed in to change notification settings - Fork 74
Mkflow27/issue783 #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mkflow27/issue783 #784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this is dead code? The functionality is handled by CreatePoolLiquidityBootstrapping, which checks the pool type and routes to the appropriate encoding method?
| 'Tokens must be different', | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these just some extra validations that were missing before?
| validateCreatePool( | ||
| input: | ||
| | CreatePoolLiquidityBootstrappingInput | ||
| | CreatePoolLiquidityBootstrappingWithMigrationInput, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is because we were missing CreatePoolLiquidityBootstrappingWithMigrationInput before?
johngrantuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of queries to address and please add a ChangeSet for the release.
We recently updated CI to skip integration tests which have been quite flaky. I added some AI generated unit tests so we have a bit more CI coverage. Would be great if you could double check them to see if they make sense or if you have any suggestions to add more.
Add Liquidity Bootstrapping Fixed Price Pool Support
Summary
Adds support for creating and initializing Fixed Price Liquidity Bootstrapping Pools (Fixed Price LBPs) in the SDK.
Changes
Core Features
PoolType.LiquidityBootstrappingFixedPriceenum valueCreatePoolLiquidityBootstrappingFixedPriceInputandFixedPriceLBPParamstypesFixedPriceLBPoolFactoryInputValidatorLiquidityBootstrappingFixedPriceKey Files
src/types.ts- Added new pool type enumsrc/entities/createPool/types.ts- Added fixed price LBP input typessrc/entities/createPool/createPoolV3/liquidityBootstrapping/createLiquidityBootstrapping.ts- Added fixed price encoding logicsrc/entities/inputValidator/liquidityBootstrapping/inputValidatorLiquidityBootstrappingFixedPrice.ts- New validator classsrc/entities/inputValidator/inputValidator.ts- Registered new validatorsrc/entities/createPool/createPoolV3/index.ts- Registered pool typetest/lib/utils/createPoolHelper.ts- Added ABI mapping for event decodingtest/v3/createPool/liquidityBootstrapping/liquidityBootstrappingFixedPrice.integration.test.ts- Integration testsValidation Rules
Testing