Skip to content

chore(repo/entity-feedback): remove workspace-specific changeset and update entity-feedback changelog#8352

Open
christoph-jerolimov wants to merge 1 commit intobackstage:mainfrom
christoph-jerolimov:cleanup-entity-feedback-workspace-changeset
Open

chore(repo/entity-feedback): remove workspace-specific changeset and update entity-feedback changelog#8352
christoph-jerolimov wants to merge 1 commit intobackstage:mainfrom
christoph-jerolimov:cleanup-entity-feedback-workspace-changeset

Conversation

@christoph-jerolimov
Copy link
Copy Markdown
Member

@christoph-jerolimov christoph-jerolimov commented Mar 27, 2026

Hey, I just made a Pull Request!

Nothing to add, cleaning up .changeset folder in repo root and added the changelog to the already released changelog.

Origin PR #6611 -- see also #8353 for the other existing changeset

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Copy link
Copy Markdown
Member

@kuangp kuangp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the commit history of when this change was merged: https://github.com/backstage/community-plugins/commits/main/workspaces/entity-feedback/plugins/entity-feedback-common it looks like this was released in this release: #7246 which means this should be later in the change logs? unless I'm missing something? also didn't realize this change never triggered it's own release for some reason 🤔

…tity-feedback changelog

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@christoph-jerolimov
Copy link
Copy Markdown
Member Author

Hi @kuangp, thanks for double-checking.

You're right, it was part of the Backstage version bump to v1.47.2 👍 Moving the changelog change.

To verify this:

It was NOT in @backstage-community/plugin-entity-feedback-backend@0.16.0 https://github.com/backstage/community-plugins/blob/%40backstage-community/plugin-entity-feedback-backend%400.16.0/workspaces/entity-feedback/plugins/entity-feedback-backend/migrations/20251223000000_add_link_to_responses.js

But it was in @backstage-community/plugin-entity-feedback-backend@0.17.0 https://github.com/backstage/community-plugins/blob/%40backstage-community/plugin-entity-feedback-backend%400.17.0/workspaces/entity-feedback/plugins/entity-feedback-backend/migrations/20251223000000_add_link_to_responses.js

Looks like I mixed the backend/frontend versions.

@christoph-jerolimov christoph-jerolimov force-pushed the cleanup-entity-feedback-workspace-changeset branch from 7754a00 to 98bd610 Compare March 27, 2026 14:53
Copy link
Copy Markdown
Member

@kuangp kuangp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@kuangp kuangp enabled auto-merge (squash) March 27, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants