fix(gitlab): handle concatenated JSON pages from glab --paginate#717
Merged
Conversation
glab api --paginate joins page responses as adjacent JSON arrays (`[...][...]`), which JSON.parse rejects. This caused MR reviews to fail with "JSON Parse error" for any MR with more than 100 changed files. Replace the bare JSON.parse with a walker that splits the output into top-level arrays (string- and depth-aware so `][` inside diff content is not mistaken for a page boundary) and merges them. Fixes #714
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glab api --paginateconcatenates page responses as adjacent JSON arrays ([...][...]), whichJSON.parserejects. MR reviews failed with "JSON Parse error" on any MR with more than 100 changed files.JSON.parseinparsePaginatedArraywith a walker that splits the output into top-level arrays and merges them. The walker tracks string state and escape sequences so a literal][inside diff content is not mistaken for a page boundary.Fixes #714
Test plan
bun test packages/shared/pr-gitlab.test.ts— 7/7 passbun test packages/shared/pr-provider.test.ts packages/shared/pr-gitlab.test.ts— 25/25 pass, no regressions