fix: accept PLANNOTATOR_PORT=0 without spurious warning#716
Merged
Conversation
Port 0 is the conventional "let OS pick a random port" value and is already the local-mode default. Validation rejected it as invalid and printed a warning, even though the fallback returned 0 anyway. Fixes #715
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLANNOTATOR_PORT=0printed[Plannotator] Warning: Invalid PLANNOTATOR_PORT "0", using defaulteven though port 0 is the conventional "OS picks a random port" value — and already the local-mode fallback.getServerPort()fromparsed > 0toparsed >= 0so0passes through silently.Fixes #715
Test plan
PLANNOTATOR_PORT=0 plannotator annotate README.md— no warning printedPLANNOTATOR_PORT=-1 plannotator annotate README.md— warning still printed (negative still invalid)PLANNOTATOR_PORT=8080 plannotator annotate README.md— still binds to 8080