Issue #7083: Icon browser/picker in core#5237
Open
docwilmot wants to merge 13 commits intobackdrop:1.xfrom
Open
Issue #7083: Icon browser/picker in core#5237docwilmot wants to merge 13 commits intobackdrop:1.xfrom
docwilmot wants to merge 13 commits intobackdrop:1.xfrom
Conversation
Replace CKEditor extraAttributes to use a single data-icon-id entry, standardizing the attribute name. In filter.pages.inc, switch the icon_selected element to use '#default_value' and populate form_state values with attributes['data-icon-id'] on submit; remove leftover debug dvm/dpm calls. In filter.js, remove unused comments and console.log debugging from the icon selection handler so clicking an icon simply updates the hidden form field. These changes clean up debug noise and align the icon attribute handling with HTML data-attribute conventions.
Move and consolidate icon browser functionality and helpers into core/system
Collaborator
|
Related to: backdrop/backdrop-issues#7083 |
Collaborator
|
Tugboat has finished building a preview for this pull request! Website: https://pr5237-ina3t5vmb6zn5wpklwgtmcfhs8lwsza2.tugboatqa.com/ This preview will automatically expire on the 6th of June, 2026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes backdrop/backdrop-issues#7083