Placing example menu item in main-menu#107
Open
stpaultim wants to merge 3 commits intobackdrop-contrib:1.x-1.xfrom
Open
Placing example menu item in main-menu#107stpaultim wants to merge 3 commits intobackdrop-contrib:1.x-1.xfrom
stpaultim wants to merge 3 commits intobackdrop-contrib:1.x-1.xfrom
Conversation
avpaderno
reviewed
Jun 24, 2024
| 'title' => 'Page Example', | ||
| // item will be created in the default internal menu, which is invisible in the | ||
| // user interface. | ||
| $items['examples/page_menu_internal'] = array( |
Member
There was a problem hiding this comment.
It is not necessary to change the route path. It can still be 'examples/page_example'.
avpaderno
reviewed
Jun 24, 2024
| // to the primary navigation (main-menu). | ||
|
|
||
| $items['examples/page_menu_visible'] = array( | ||
| 'title' => 'Page Menu Visible', |
Member
There was a problem hiding this comment.
Page Example: Visible Menu would be a better title which makes clear from where the menu item comes from (as most of the strings used by the example modules and shown in the user interface.)
Clearly, this does not hold true for the menu item title used for examples/page_menu_visible/simple, as that menu item is shown after clicking on the parent menu item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #105
I am not very confident that this is the correct fix. But, give me some feedback and I'll try again.