Allow multiple authors in videos page#1854
Merged
hzoo merged 2 commits intobabel:masterfrom Oct 8, 2018
Merged
Conversation
Contributor
|
Deploy preview for babel ready! Built with commit 77dafdb |
hzoo
approved these changes
Oct 8, 2018
Member
hzoo
left a comment
hzoo
left a comment
There was a problem hiding this comment.
looks fine to me!
I guess we could of gone with all of the data being an array but this works since I suppose most of the videos will be single author
Contributor
Author
|
Yup. Considered that. Ended up going for the flatter approach because I assumed most videos will be single author. |
Contributor
Author
|
I think this is ready to be merged. Please let me know if you need squashing or rebasing. |
Member
|
Didn't need to do anything, just time. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #1849
This allows displaying two authors for the same talk.
It also changes the data format for videos from yml to js.
This may not be idiomatic React, since I don't have a lot of experience in it. Please point out where I can be more idiomatic.