Skip to content

Please consider the following formatting changes to #14042 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #14042 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
#include <TH1F.h>

#include <array>
#include <iostream>

Check failure on line 19 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[include-iostream] 

Do not include iostream. Use O2 logging instead.
// O2 includes
#include "Common/Core/RecoDecay.h"
#include "Common/Core/TrackSelection.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/Core/RecoDecay.h"

#include "Framework/ASoAHelpers.h"
#include "Framework/AnalysisDataModel.h"
Expand Down Expand Up @@ -140,11 +140,11 @@
Int_t testc1 = 0, testc2 = 0, testc3 = 0;
array<Int_t, nBins> binningM;
array<Int_t, 5> countTracks{0, 0, 0, 0, 0};
array<array<array<Double_t, nBins>, 5>, 6> fqEvent;

Check failure on line 143 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
array<array<array<Double_t, nBins>, 5>, 6> fqEventSampled;

Check failure on line 144 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
array<array<Double_t, nBins>, 5> binConEvent;

Check failure on line 145 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
array<array<array<Double_t, nBins>, 5>, 6> binConEventSampled;

Check failure on line 146 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
array<array<array<Double_t, nBins>, 5>, 6> errorFq = {{{{{0, 0, 0, 0, 0}}}}};

Check failure on line 147 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
std::vector<std::shared_ptr<TH2>> mHistArrReset;
std::vector<std::shared_ptr<TH1>> mHistArrQA;
std::vector<std::shared_ptr<TH1>> mFqBinFinal;
Expand All @@ -153,7 +153,7 @@
std::vector<std::shared_ptr<TH1>> mBinConFinalSampled;
std::vector<std::shared_ptr<TH1>> mFqError;
// max number of bins restricted to 5
static constexpr array<std::string_view, 5>

Check failure on line 156 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
mbinNames{"bin1/", "bin2/", "bin3/", "bin4/", "bin5/"};
void init(o2::framework::InitContext&)
{
Expand Down Expand Up @@ -194,11 +194,11 @@
for (auto iM = 0; iM < nBins; ++iM) {
auto mHistsR = std::get<std::shared_ptr<TH2>>(histos.add(Form("bin%i/Reset/mEtaPhi%i", iPt + 1, iM), Form("#eta#phi_%i for bin %.2f-%.2f;#eta;#phi", iM, confPtBins.value[2 * iPt], confPtBins.value[2 * iPt + 1]), HistType::kTH2F, {{binningM[iM], -0.8, 0.8}, {binningM[iM], 0, 2 * TMath::Pi()}}));
mHistArrReset.push_back(mHistsR);
for (auto iq = 0; iq < 6; ++iq) {

Check failure on line 197 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
tmpFqErr[iq][iPt][iM] = new TH1D(Form("tmpFqErr%i%i%i", iq, iPt, iM), Form("tmpFqErr%i%i%i", iq, iPt, iM), 100, 0, 10);
}
}
for (auto i = 0; i < 6; ++i) {

Check failure on line 201 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
auto mHistFq = std::get<std::shared_ptr<TH1>>(histos.add(Form("mFinalFq%i_bin%i", i + 2, iPt + 1), Form("Final F_%i for bin %.2f-%.2f;M", i + 2, confPtBins.value[2 * iPt], confPtBins.value[2 * iPt + 1]), HistType::kTH1F, {{nBins, -0.5, nBins - 0.5}}));
mFqBinFinal.push_back(mHistFq);
auto mHistAv = std::get<std::shared_ptr<TH1>>(histos.add(Form("mFinalAvBin%i_bin%i", i + 2, iPt + 1), Form("Final AvBin_%i for bin %.2f-%.2f;M", i + 2, confPtBins.value[2 * iPt], confPtBins.value[2 * iPt + 1]), HistType::kTH1F, {{nBins, -0.5, nBins - 0.5}}));
Expand Down Expand Up @@ -278,7 +278,7 @@
if (compSample) {
mBinConFinalSampled[iPt * 6 + iq]->Fill(iM, binConEventSampled[iq][iPt][iM] / confSamplesize);

double tmp = (fqEventSampled[iq][iPt][iM] / (confSamplesize)) / (pow(binConEventSampled[iq][iPt][iM] / (confSamplesize), (iq + 2)));

Check failure on line 281 in PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
mFqBinFinalSampled[iPt * 6 + iq]->Fill(iM, tmp);
tmpFqErr[iq][iPt][iM]->Fill(tmp);
errorFq[iq][iPt][iM] += TMath::Power(fqEventSampled[iq][iPt][iM] / (confSamplesize), 2);
Expand Down
Loading