chore: replace placeholder lint with real typecheck and workflow lint gates#6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 follow-up: remove placeholder quality gate and enforce real checks that pass in current repo state.
Changes
typechecknow runs real TypeScript no-emit checks:bunx tsc -p packages/core/tsconfig.json --noEmitbunx tsc -p packages/cli/tsconfig.json --noEmitlintnow runs a real YAML/workflow style check:bunx prettier --check .github/workflows/*.ymlWhy
The previous
lintscript was a placeholder echo. This makes CI quality checks concrete and enforceable while broader repo-wide lint/test stabilization continues.Validation
bun run typecheckbun run lint