Skip to content

perf(Core): Optimize damage/heal hot paths and gate Mythic AI #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nyeriah merged 1 commit into from
May 3, 2026
Merged

perf(Core): Optimize damage/heal hot paths and gate Mythic AI #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions conf/mod-zone-difficulty.conf.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,13 @@ ModZoneDifficulty.Mythicmode.HpModifier = 2.0
# 1 - Enabled

ModZoneDifficulty.Mythicmode.InNormalDungeons = 0

#
# ModZoneDifficulty.MythicmodeAI.Enable
# Description: Enable scripted Mythic mode AI from `zone_difficulty_mythicmode_ai`.
# When disabled, OnUnitEnterCombat skips the AI lookup entirely
# for every unit that enters combat in a mythic instance.
# Default: 0 - Disabled
# 1 - Enabled

ModZoneDifficulty.MythicmodeAI.Enable = 0
13 changes: 9 additions & 4 deletions src/ZoneDifficulty.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,25 +194,30 @@ class ZoneDifficulty
float MythicmodeHpModifier{ 2.0 };
bool MythicmodeEnable{ false };
bool MythicmodeInNormalDungeons{ false };
bool MythicmodeAIEnable{ false };
bool UseVendorInterface{ false };
bool SpellBuffOnlyBosses{ false };
bool MeleeBuffOnlyBosses{ false };
bool IsBlackTempleDone{ false };
bool IsSunwellPlateauDone{ false };
std::vector<uint32> DailyHeroicQuests;
std::map<uint32, uint32> HeroicTBCQuestMapList;
std::map<uint32, uint8> EncounterCounter;
std::map<uint32, uint8> Expansion;
std::unordered_map<uint32, uint8> Expansion;
std::map<uint32, CreatureOverrideData> CreatureOverrides;
std::map<uint32, uint32> EncountersInProgress;
std::map<uint32, std::string> ItemIcons;
std::map<uint8, ZoneDifficultyRewardData> TierRewards;

typedef std::map<uint32, std::map<uint32, ZoneDifficultyNerfData> > ZoneDifficultyNerfDataMap;
// Inner phase map remains std::map: GetLowestMatchingPhase() iterates it
// and relies on ascending key order to return the lowest matching phase.
typedef std::unordered_map<uint32, std::map<uint32, ZoneDifficultyNerfData> > ZoneDifficultyNerfDataMap;
ZoneDifficultyNerfDataMap NerfInfo;
typedef std::map<uint32, std::map<uint32, ZoneDifficulySpellOverrideData> > ZoneDifficultySpellNerfMap;
typedef std::unordered_map<uint32, std::unordered_map<uint32, ZoneDifficulySpellOverrideData> > ZoneDifficultySpellNerfMap;
ZoneDifficultySpellNerfMap SpellNerfOverrides;
typedef std::map<uint32, std::vector<uint32> > ZoneDifficultyDisablesMap;
ZoneDifficultyDisablesMap DisallowedBuffs;
typedef std::map<uint32, bool> ZoneDifficultyMythicmodeInstDataMap;
typedef std::unordered_map<uint32, bool> ZoneDifficultyMythicmodeInstDataMap;
ZoneDifficultyMythicmodeInstDataMap MythicmodeInstanceData;
typedef std::map<uint32, std::vector<ZoneDifficultyMythicmodeMapData> > ZoneDifficultyMythicmodeLootMap;
ZoneDifficultyMythicmodeLootMap MythicmodeLoot;
Expand Down
Loading
Loading