A11y: high-confidence round3 semantic and accordion fixes#5645
Open
accesswatch wants to merge 1 commit into
Open
A11y: high-confidence round3 semantic and accordion fixes#5645accesswatch wants to merge 1 commit into
accesswatch wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Accessibility-focused remediation pass to improve semantic correctness and assistive-technology support across shared navigation and accordion components in the Quickstart Drupal distribution.
Changes:
- Fixes accordion ARIA relationships and Bootstrap accordion parenting to correctly associate headers/panels and collapse behavior.
- Improves mobile header/offcanvas control accessible names and removes invalid/redundant interactive attributes on links/buttons.
- Normalizes breadcrumb landmark labeling via translation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
themes/custom/az_barrio/templates/navigation/breadcrumb.html.twig |
Translates breadcrumb landmark label for consistent announcement. |
themes/custom/az_barrio/templates/layout/page.html.twig |
Adds explicit accessible names for mobile header/offcanvas controls. |
modules/custom/az_select_menu/src/Plugin/Block/AzSelectMenu.php |
Removes redundant role/tabindex from native button attributes. |
modules/custom/az_core/src/Plugin/Block/MobileNavBlock.php |
Removes invalid/redundant type/role attributes from rendered links. |
modules/custom/az_accordion/templates/az-accordion.html.twig |
Corrects aria-labelledby and data-bs-parent targeting for accordion items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div class="offcanvas offcanvas-end mw-100 w-100 bg-white d-flex d-lg-none overflow-y-auto" tabindex="-1" id="azMobileNav" aria-label="Mobile navigation"> | ||
| <div class="offcanvas-header sticky-top p-0 mb-2 {{ az_header_blue ? 'text-bg-blue' : 'text-bg-red' }} text-bg-red d-flex justify-content-between align-items-center"> | ||
| <a href="/" class="btn btn-arizona-header"> | ||
| <a href="/" aria-label="{{ 'Go to homepage'|t }}" class="btn btn-arizona-header"> |
Contributor
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue fixes in this PR
modules/custom/az_accordion/templates/az-accordion.html.twig)aria-labelledbyto reference the header button ID (not the panel ID).data-bs-parentto reference the accordion container ID.modules/custom/az_core/src/Plugin/Block/MobileNavBlock.php)type=buttonand redundantrole=buttonattributes from links.modules/custom/az_select_menu/src/Plugin/Block/AzSelectMenu.php)role=buttonandtabindexfrom native<button>.themes/custom/az_barrio/templates/layout/page.html.twig)themes/custom/az_barrio/templates/navigation/breadcrumb.html.twig)Breadcrumblandmark label.Test plan