A11y scan hardening: block non-AJAX mobile nav callback access#5642
Open
accesswatch wants to merge 2 commits into
Open
A11y scan hardening: block non-AJAX mobile nav callback access#5642accesswatch wants to merge 2 commits into
accesswatch wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Hardens the az_core.mobile_nav_callback controller endpoint so it only serves Drupal AJAX command payloads to legitimate AJAX requests, reducing accessibility scanner false-positives caused by crawlers treating the callback response as a standalone page.
Changes:
- Inject
request_stackintoMobileNavController. - Reject non-AJAX requests by throwing
NotFoundHttpException(404) before building the AJAX response.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue types targeted from CSV
html-has-langdocument-titlelabelThese were reported on
/az_core/mobile_nav_callback/...URLs where scanners treated AJAX payloads as full pages.Change
modules/custom/az_core/src/Controller/MobileNavController.phprequest_stackand checksisXmlHttpRequest().404for non-AJAX requests.Impact