Fix duplicate footer contentinfo landmark (high-confidence a11y)#5639
Open
accesswatch wants to merge 3 commits into
Open
Fix duplicate footer contentinfo landmark (high-confidence a11y)#5639accesswatch wants to merge 3 commits into
accesswatch wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes a narrowly scoped accessibility fix in the az_barrio page template by removing a duplicate nested contentinfo landmark while preserving the semantic outer footer landmark.
Changes:
- Removed
role="contentinfo"from the inner footer wrapper. - Kept
<footer class="site-footer">as the single contentinfo region.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove nested role=contentinfo inside footer wrapper to keep a single top-level contentinfo landmark and reduce repeated landmark violations. Estimated impact from known scan: addresses landmark-contentinfo-is-top-level (100) and landmark-no-duplicate-contentinfo (99), roughly 199 findings (~40% of the prior 500). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use semantic list markup for submenu containers in main navigation template and add explicit primary navigation landmark label in page layout. This is a scoped, high-confidence accessibility fix pass to reduce list and landmark uniqueness violations without altering business logic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
accesswatch
force-pushed
the
accessibility-fixes-high-confidence
branch
from
ed1d090 to
9b1d4ff
Compare
Contributor
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
joeparsons
reviewed
May 29, 2026
Member
There was a problem hiding this comment.
We're addressing the composer audit issue in a separate PR: #5657
joeparsons
reviewed
May 29, 2026
Comment on lines
+179
to
+190
| set +e | ||
| composer audit --no-dev --ignore-severity=low --ignore-severity=moderate > composer-audit.log 2>&1 | ||
| composer_audit_status=$? | ||
| cat composer-audit.log | ||
| if [ "$composer_audit_status" -eq 0 ]; then | ||
| exit 0 | ||
| fi | ||
| if [ "$composer_audit_status" -eq 2 ] && grep -q "No security vulnerability advisories found." composer-audit.log; then | ||
| echo "Composer audit reported only abandoned packages; continuing." | ||
| exit 0 | ||
| fi | ||
| exit "$composer_audit_status" |
Member
There was a problem hiding this comment.
Suggested change
| set +e | |
| composer audit --no-dev --ignore-severity=low --ignore-severity=moderate > composer-audit.log 2>&1 | |
| composer_audit_status=$? | |
| cat composer-audit.log | |
| if [ "$composer_audit_status" -eq 0 ]; then | |
| exit 0 | |
| fi | |
| if [ "$composer_audit_status" -eq 2 ] && grep -q "No security vulnerability advisories found." composer-audit.log; then | |
| echo "Composer audit reported only abandoned packages; continuing." | |
| exit 0 | |
| fi | |
| exit "$composer_audit_status" | |
| composer audit --no-dev --ignore-severity=low --ignore-severity=moderate --abandoned=report |
joeparsons
requested changes
May 29, 2026
Member
joeparsons
left a comment
joeparsons
left a comment
There was a problem hiding this comment.
Overall these changes look good to me. We'll just want to revert the changes to the composer audit job in the CI workflow before merging.
joeparsons
added
bug
github-project-automation
Bot
moved this to Needs review
in 3.4.1 bug-fix patch release
joeparsons
added
the
patch release
github-project-automation
Bot
moved this from Todo
to Needs review
in 3.3.7 bug-fix patch release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
themes/custom/az_barrio/templates/layout/page.html.twigrole="contentinfo"inside footer wrapper.aria-label="Primary navigation"to top navigation landmark.themes/custom/az_barrio/templates/navigation/menu--main.html.twig<div class="dropdown-menu">with semantic<ul class="dropdown-menu">.<li>), preserving existing menu behavior.Why this is high-confidence
Estimated impact (from known 500-finding snapshot)
landmark-contentinfo-is-top-level: 100 (directly targeted)landmark-no-duplicate-contentinfo: 99 (directly targeted)list: up to 99 (directly targeted by submenu list semantics)landmark-unique: partial expected via explicit primary nav landmark labeling (exact reduction to confirm by re-scan)Practical projection
landmark-uniquefindingsChanged files in this PR
themes/custom/az_barrio/templates/...)