Add CloudFormation solution tag stack for Terraform infra#67
Open
kunanit wants to merge 2 commits intoawslabs:mainfrom
Open
Add CloudFormation solution tag stack for Terraform infra#67kunanit wants to merge 2 commits intoawslabs:mainfrom
kunanit wants to merge 2 commits intoawslabs:mainfrom
Conversation
Add an empty CloudFormation stack to carry the AWS solution tag, mirroring the CDK FastMainStack description. Also bump Terraform version to 0.4.0-tf.1 and update version bump playbooks accordingly.
|
Latest scan for commit: Security Scan ResultsScan Metadata
SummaryScanner ResultsThe table below shows findings by scanner, with status based on severity thresholds and dependencies: Column Explanations: Severity Levels (S/C/H/M/L/I):
Other Columns:
Scanner Results:
Severity Thresholds (Thresh Column):
Threshold Source: Values in parentheses indicate where the threshold is configured:
Statistics calculation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an empty CloudFormation stack to carry the AWS solution tag for Terraform deployments, mirroring the CDK
FastMainStackdescription. Also bump Terraform version to0.4.0-tf.1and update version bump playbooks to include the new stack description step.Version
Changes [CDK parity related]
CloudFormation Solution Tag Stack
Adds an
aws_cloudformation_stackresource that deploys an empty CloudFormation stack whoseDescriptioncarries the AWS solution tag identifier (uksb-v6dos0t5g8), matching how CDK embeds the tag in itsFastMainStackdescription.CDK references
infra-cdk/lib/fast-main-stack.ts— stack description field containing solution tagComponents
aws_cloudformation_stack.solution_tag— Empty CloudFormation stack with aWaitConditionHandleresource, used solely to surface the solution tag in CloudFormationVariables/Outputs:
Implementation Notes:
CDK natively embeds the solution tag in its stack description. Terraform has no equivalent mechanism for associating a CloudFormation-style solution identifier with a deployment, so we create a minimal CloudFormation stack via the
aws_cloudformation_stackresource. The stack contains only aWaitConditionHandle(the simplest no-op CloudFormation resource) and carries the solution tag in itsDescriptionfield. The stack is named${var.stack_name_base}-solution-tag.Other Changes
infra-terraform/VERSIONfrom0.4.0-tf.0to0.4.0-tf.1docs/VERSION_BUMP_PLAYBOOK.mdto includeinfra-terraform/main.tfstack description as a version bump step (now step 7)infra-terraform/TF_VERSION_BUMP_PLAYBOOK.mdto include themain.tfdescription update step and corrected the git tag format tov<VERSION-tf.X>Testing
Documentation
docs/VERSION_BUMP_PLAYBOOK.mdwith new step formain.tfstack descriptioninfra-terraform/TF_VERSION_BUMP_PLAYBOOK.mdwith new procedure step and corrected tag format