refactor(infra-cdk): migrate to L2 constructs and replace NestedStacks with Constructs#6
refactor(infra-cdk): migrate to L2 constructs and replace NestedStacks with Constructs#6adam-weber wants to merge 4 commits intoawslabs:mainfrom
Conversation
| pattern: strands-single-agent # Available patterns: strands-single-agent, langgraph-single-agent | ||
| deployment_type: docker # Available deployment types: docker (default), zip | ||
| agent_name: StrandsAgent | ||
| network_mode: PUBLIC # Available: PUBLIC, PRIVATE (PRIVATE requires VPC configuration) |
There was a problem hiding this comment.
What is the reason for making PUBLIC VPC instead of default Private?
There was a problem hiding this comment.
@harshitkgupta PUBLIC is the current default with CfnParams on main.
|
P;ease test deployment of current code and attach testing proof. |
Testing ProofCode checks:
Deployment:
End-to-end test:
UI:
|
|
@adam-weber I'm looking at this again. I took an initial look last week, and I was able to deploy your changes which looked good. When I tried to deploy this today, I got this error: Note sure if anything changed in the underlying L2 constructs between then and now. Can you please destroy, do a fresh |
|
@brianz - this is a bug with CDK and a recent AgentCore service change. Tracking here: aws/aws-cdk#36826 |
|
@adam-weber Any update on this? I have seen that there are also L3 constructs now available too, and not sure how that affects this PR. Note we've made some big changes to FAST since you submitted this PR, so it will need some attention to resolve the conflicts. I'm happy to help or review as needed. |

Summary
Refactors CDK infrastructure to follow best practices by using L2 constructs where available and simplifying the stack architecture.
Changes
L2 Constructs
NestedStacks -> Constructs
CfnParameters -> config.yaml
Why
validate them. CDK docs recommend against them.