Skip to content

Checks if futures are done in AIOHttpClientStreamUnified to avoid race condition #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolastomeo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Checks if futures are done in AIOHttpClientStreamUnified to avoid race condition #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions awscrt/aio/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,8 @@ def _on_body(self, chunk: bytes) -> None:
"""Process body chunk on the correct event loop thread."""
if self._chunk_futures:
future = self._chunk_futures.popleft()
future.set_result(chunk)
if not future.done():
future.set_result(chunk)
else:
self._received_chunks.append(chunk)

Expand All @@ -309,7 +310,8 @@ def _on_complete(self, error_code: int) -> None:
# Resolve all pending chunk futures with an empty string to indicate end of stream
while self._chunk_futures:
future = self._chunk_futures.popleft()
future.set_result("")
if not future.done():
future.set_result("")

async def _set_request_body_generator(self, body_iterator: AsyncIterator[bytes]):
...
Expand Down