Skip to content

submodule update #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TingDaoK merged 3 commits into from
May 26, 2026
Merged

submodule update #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3d90ed
submodule update
TingDaoK May 26, 2026
ba62989
make sure it's idempotent
TingDaoK May 26, 2026
83a3965
Apply suggestion from @azkrishpy
TingDaoK May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crt/aws-c-s3
Open in desktop
Submodule aws-c-s3 updated 21 files
+2 −0 .builder/actions/mock_server_setup.py
+5 −4 .github/workflows/ci.yml
+1 −1 .github/workflows/clang-format.yml
+1 −1 .github/workflows/codecov.yml
+45 −18 README.md
+6 −2 include/aws/s3/private/s3_checksum_context.h
+8 −5 include/aws/s3/private/s3_util.h
+69 −13 source/s3_auto_ranged_put.c
+11 −6 source/s3_checksum_context.c
+2 −4 source/s3_checksums.c
+18 −8 source/s3_copy_object.c
+12 −3 source/s3_default_meta_request.c
+1,044 −1,031 source/s3_endpoint_resolver/aws_s3_endpoint_rule_set.c
+7 −2 source/s3_list_objects.c
+7 −3 source/s3_list_parts.c
+1 −2 source/s3_request_messages.c
+9 −25 source/s3_util.c
+1 −0 tests/CMakeLists.txt
+35 −5 tests/s3_checksum_context_test.c
+1 −1 tests/s3_checksum_stream_test.c
+22 −1 tests/s3_util_tests.c
7 changes: 6 additions & 1 deletion src/main/java/software/amazon/awssdk/crt/http/Http1StreamManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,12 @@ public void onResponseComplete(HttpStreamBase stream, int errorCode) {
}
}, useManualDataWrites);
completionFuture.complete((HttpStream) stream);
/* Active the stream for user */
/**
* Activate the stream for user after completing the future, otherwise the
* callbacks may be invoked without the stream being completed.
*
* `activate` is idempotent.
**/
try {
stream.activate();
} catch (CrtRuntimeException e) {
Expand Down
4 changes: 4 additions & 0 deletions src/native/http_request_response.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,10 @@ JNIEXPORT void JNICALL Java_software_amazon_awssdk_crt_http_HttpStreamBase_httpS

struct http_stream_binding *binding = (struct http_stream_binding *)jni_stream_binding;
struct aws_http_stream *stream = binding->native_stream;
if (binding->java_http_stream_base) {
/* Already activated */
return;
}

if (stream == NULL) {
aws_jni_throw_runtime_exception(env, "HttpStream is null.");
Expand Down
Loading