Delegate ReDrive APIs to the underlying SQS client#178
Open
stefan-sq wants to merge 1 commit into
Open
Conversation
AmazonSQSExtendedClientBase and AmazonSQSExtendedAsyncClientBase did not override startMessageMoveTask, listMessageMoveTasks, or cancelMessageMoveTask. Calls fell through to the SqsClient / SqsAsyncClient interface default methods, which throw UnsupportedOperationException, breaking DLQ redrive for any consumer that wraps an SQS client with the extended client (for S3 payload offloading). These operations move, list, and cancel server-side message move tasks between queues; they do not interact with message payloads, so no extended-client-specific handling is required — plain delegation is sufficient. This mirrors the fix landed for the v1 SDK branch in: awslabs@f0959cb
Author
|
cc: @mit-aws, @ziyanli-amazon, @jagdev-aws, I see you all have approved some of the most recently merged PRs, hope someone can take a look here, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
AmazonSQSExtendedClientBaseandAmazonSQSExtendedAsyncClientBasedo not overridestartMessageMoveTask,listMessageMoveTasks, orcancelMessageMoveTask. Calls fall through to theSqsClient/SqsAsyncClientinterface default methods, which throwUnsupportedOperationException, breaking DLQ redrive for any consumer that wraps an SQS client with the extended client for S3 payload offloading.Reproduction
Fix
Add plain delegating overrides in both base classes. These server-side move operations don't interact with message payloads, so no extended-client-specific handling is required.
Prior art
This mirrors the equivalent fix landed for the v1 SDK branch in f0959cb.
Tests
Added one delegation test per method in both
AmazonSQSExtendedClientTestandAmazonSQSExtendedAsyncClientTest. All 94 tests pass locally.