fix: import DIR_PARAM_NAME and SAGEMAKER_OUTPUT_LOCATION directly in local/image.py#5824
Open
egorkosaretsky wants to merge 1 commit intoaws:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
local/image.pyreferencedsagemaker.serve.model_builder.DIR_PARAM_NAMEandsagemaker.serve.model_builder.SAGEMAKER_OUTPUT_LOCATIONvia lazy attribute access on the top-levelsagemakermodule. This relies onsagemaker.serve.model_builderhaving been imported previously, which is not guaranteed. When using local mode without a prior import ofsagemaker.serve.model_builder, this raises:This affects any user of SageMaker local mode in v3 and is the root cause of the issue reported in #5371.
Fix
Import
DIR_PARAM_NAMEandSAGEMAKER_OUTPUT_LOCATIONexplicitly at the top ofimage.pyinstead of accessing them via the lazy module attribute chain.Test
Existing local mode unit tests cover the affected code paths.