Skip to content

Remove experiment_config parameter for aws_batch #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviruthen merged 1 commit into from
Jan 12, 2026
Merged

Remove experiment_config parameter for aws_batch #5473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions sagemaker-train/src/sagemaker/train/aws_batch/training_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def submit(
share_identifier: Optional[str] = None,
timeout: Optional[Dict] = None,
tags: Optional[Dict] = None,
experiment_config: Optional[Dict] = None,
) -> TrainingQueuedJob:
"""Submit a queued job and return a QueuedJob object.

Expand All @@ -54,9 +53,6 @@ def submit(
share_identifier: Share identifier for Batch job.
timeout: Timeout configuration for Batch job.
tags: Tags apply to Batch job. These tags are for Batch job only.
experiment_config: Experiment management configuration.
Optionally, the dict can contain four keys:
'ExperimentName', 'TrialName', 'TrialComponentDisplayName' and 'RunName'.

Returns: a TrainingQueuedJob object with Batch job ARN and job name.

Expand All @@ -71,11 +67,6 @@ def submit(
raise ValueError(
"TrainingQueue requires using a ModelTrainer with Mode.SAGEMAKER_TRAINING_JOB"
)
if experiment_config is not None:
logging.warning(
"ExperimentConfig is not supported for ModelTrainer. "
"It will be ignored when submitting the job."
)
training_payload = training_job._create_training_job_args(
input_data_config=inputs, boto3=True
)
Expand Down Expand Up @@ -111,7 +102,6 @@ def map(
share_identifier: Optional[str] = None,
timeout: Optional[Dict] = None,
tags: Optional[Dict] = None,
experiment_config: Optional[Dict] = None,
) -> List[TrainingQueuedJob]:
"""Submit queued jobs to the provided estimator and return a list of TrainingQueuedJob objects.

Expand All @@ -124,15 +114,10 @@ def map(
share_identifier: Share identifier for the Batch jobs.
timeout: Timeout configuration for the Batch jobs.
tags: Tags apply to Batch job. These tags are for Batch job only.
experiment_config: Experiment management configuration.
Optionally, the dict can contain four keys:
'ExperimentName', 'TrialName', 'TrialComponentDisplayName' and 'RunName'.

Returns: a list of TrainingQueuedJob objects with each Batch job ARN and job name.

"""
if experiment_config is None:
experiment_config = {}

if job_names is not None:
if len(job_names) != len(inputs):
Expand All @@ -153,7 +138,6 @@ def map(
share_identifier,
timeout,
tags,
experiment_config,
)
queued_batch_job_list.append(queued_batch_job)

Expand Down
Loading