test(integv2): remove dynamic record sizing test and related cleanup #5644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaukabrizvi
changed the title
kaukabrizvi
changed the title
kaukabrizvi
changed the title
dougch
approved these changes
Dec 2, 2025
| Swap the device's current MTU for the requested MTU. | ||
| Return the original MTU so it can be reset later. | ||
| """ | ||
| cmd = ["ip", "link", "show", device] |
Contributor
There was a problem hiding this comment.
We can confirm post merge, but I believe this line can also go, if we're not mucking about with the interface settings elsewhere...
jmayclin
approved these changes
Dec 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR removes the Python integV2 test for dynamic record sizing.
Why
The integration test for dynamic record sizing is now fully covered by the Rust integration test added in #5608 which now runs in CI after #5623 was merged. The old tcpdump-based packet-fragmentation test and the supporting infrastructure is no longer required.
How
Removed the integv2 dynamic record sizing test, its supporting fixtures/providers, cleaned up related docs, and dropped all CI references to it.
Callouts
N/A
Testing
IntegV2 will run on this PR; a passing run confirms that the cleanup is safe and non-breaking. The Rust integration tests—which now include dynamic record sizing—also run in CI, ensuring this code path remains fully covered.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.