-
Notifications
You must be signed in to change notification settings - Fork 72
Add edge connection discovery on schema refresh #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edge connection discovery on schema refresh #1484
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
===========================================
+ Coverage 47.81% 63.32% +15.51%
===========================================
Files 382 316 -66
Lines 8525 6642 -1883
Branches 3159 2301 -858
===========================================
+ Hits 4076 4206 +130
+ Misses 3070 1702 -1368
+ Partials 1379 734 -645
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
59ee527 to
a9f5d0d
Compare
| }); | ||
| }, | ||
| ); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just moved in to the query file since that is the only place it is used.
894f574 to
764061f
Compare
764061f to
49cfbea
Compare
Description
Add edge connection discovery that runs during schema sync/refresh. This enables
the schema graph to display edge labels showing which vertex types are connected
by each edge type.
Changes:
edgeConnectionsQueryto discover edge connections between vertextypes
useSchemaSyncto integrate edge connection discoveryEdgeDiscoveryBoundarycomponent for schema graphGoals:
Validation
This one was tough to test. I added new debug actions to setup the schema state in different scenarios. I also had connections that work perfectly, and connections that don't work to test more real world situations.
Schema Explorer
In schema explorer, if the edge connection discovery query had previously failed, then an error is shown with a retry button.
Connection Info
In the connection info screen, the last sync info area is updated to represent edge discovery errors, if they exist. The retry button executes a full refresh.
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.