Add HF SGLang 0.5.12#6121
Conversation
| base_framework: &BASE_FRAMEWORK sglang | ||
| framework: &FRAMEWORK !join [ "huggingface_", *BASE_FRAMEWORK] | ||
| version: &VERSION "0.5.8" | ||
| short_version: &SHORT_VERSION "0.5" |
There was a problem hiding this comment.
The short version here should be 0.5.8 since you rename the Dockerfile folder name, otherwise it cannot find the file.
| @@ -0,0 +1,12 @@ | |||
| # telemetry.sh | |||
| #!/bin/bash | |||
| if [ -f /usr/local/bin/deep_learning_container.py ] && [[ -z "${OPT_OUT_TRACKING}" || "${OPT_OUT_TRACKING,,}" != "true" ]]; then | |||
There was a problem hiding this comment.
Are you planning to add telemetry for HuggingFace image? This script is used for dlc telemetry data tracking. I believe HuggingFace has different contract for revenue tracking, so this may be not necessary.
And some information just FYI, if we need to make it work, we need to copy it to the Dockerfile and invoke in the entrypoint
https://github.com/aws/deep-learning-containers/blob/master/sglang/x86_64/gpu/Dockerfile#L29-L36
https://github.com/aws/deep-learning-containers/blob/master/sglang/build_artifacts/sagemaker_entrypoint.sh#L4
And this is the framework it accepts https://github.com/aws/deep-learning-containers/blob/master/src/deep_learning_container.py#L242
There was a problem hiding this comment.
Hmmm honestly I think we're not using it, but that file gets generated when building the image and sometimes it get's added to the tracking (by mistake). I think I can just remove it
Purpose
This PR upgrades the HF SGLang DLC from version
0.5.8to0.5.12.Test Plan
Test Result
Toggle if you are merging into master Branch
By default, docker image builds and tests are disabled. Two ways to run builds and tests:
How to use the helper utility for updating dlc_developer_config.toml
Assuming your remote is called
origin(you can find out more withgit remote -v)...python src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -cp originpython src/prepare_dlc_dev_environment.py -b </path/to/buildspec.yml> -t sanity_tests -cp originpython src/prepare_dlc_dev_environment.py -rcp originNOTE: If you are creating a PR for a new framework version, please ensure success of the local, standard, rc, and efa sagemaker tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = truesagemaker_efa_tests = truesagemaker_rc_tests = truesagemaker_local_tests = trueHow to use PR description
Use the code block below to uncomment commands and run the PR CodeBuild jobs. There are two commands available:# /buildspec <buildspec_path># /buildspec pytorch/training/buildspec.yml# /tests <test_list># /tests sanity security ec2sanity, security, ec2, ecs, eks, sagemaker, sagemaker-local.Toggle if you are merging into main Branch
PR Checklist
pre-commit run --all-fileslocally before creating this PR. (Read DEVELOPMENT.md for details).